Set GOMODCACHE to writable directory in ko sample build strategy #2082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
pull-request-size
bot
added
the
size/XS
openshift-ci
bot
added
release-note
SaschaSchwarze0
changed the title
openshift-ci
bot
added
the
approved
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee, sayan-biswas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes a problem with certain sources in the ko build strategy after the root file system was made readonly in #2020.
Basically for modules with dependencies but without vendoring, Go downloads the modules to the GOMODCACHE directory which is
/go/pkg/modby default. And that directory is not anymore writable.I re-used the gocache volume as persistence here also makes sense for those that overwrite the volume.
/cc hasanawad94
/kind bug
Submitter Checklist
Release Notes