Add --runtime-class flag to buildrun create #366
Conversation
Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
openshift-ci
bot
added
kind/feature
pull-request-size
bot
added
the
size/M
|
Note: The shipwright-io/build dependency is currently pointing to the main branch since the RuntimeClassName field was added in shipwright-io/build#2079 but not yet included in a release. This can be updated to a proper release version once available. |
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
/approve
Looks good to me, needs a 2nd set of eyes for lgtm
| github.com/schollz/progressbar/v3 v3.18.0 | ||
| github.com/shipwright-io/build v0.18.0 | ||
| github.com/spf13/cobra v1.10.1 | ||
| github.com/shipwright-io/build v0.18.2-0.20260112084729-e48a9ff9aa57 |
There was a problem hiding this comment.
👍 - necessary to get the new API. We will update to v0.19.0 when we get ready to release next month.
| ) | ||
| } | ||
|
|
||
| // buildRuntimeClassNameFlag registers flags for adding BuildRunSpec.RuntimeClassName |
| t.Run(".spec.runtimeClassName", func(_ *testing.T) { | ||
| err := flags.Set(RuntimeClassNameFlag, *expected.RuntimeClassName) | ||
| g.Expect(err).To(o.BeNil()) | ||
|
|
||
| g.Expect(expected.RuntimeClassName).To(o.Equal(spec.RuntimeClassName), "spec.runtimeClassName") | ||
| }) | ||
|
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
2 participants
Changes
Adds support for the
--runtime-classflag.Fixes #363
/kind feature
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes