Add @shlinkio/dashboard-server local package in src folder#682
Draft
acelaya wants to merge 3 commits intoshlinkio:developfrom
Draft
Add @shlinkio/dashboard-server local package in src folder#682acelaya wants to merge 3 commits intoshlinkio:developfrom
acelaya wants to merge 3 commits intoshlinkio:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #682 +/- ##
========================================
Coverage 76.94% 76.94%
========================================
Files 90 90
Lines 798 798
Branches 97 97
========================================
Hits 614 614
Misses 98 98
Partials 86 86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c886761 to
644ad2d
Compare
9c0fe7c to
198a977
Compare
198a977 to
d1cf685
Compare
d1cf685 to
95a9621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589
In order to be able to use all server domain code in production, for the react-router app, but also other entry points, this PR extracts that to its own meta-package, that is marked as external for vite and bundled individually.
That way, react-router's server bundle does not include that code, but instead just consume it as another external dependency.
Other entry points can do the same.