Fix error when trying to persist non-utf-8 title#2569
Merged
acelaya merged 1 commit intoshlinkio:developfrom Jan 9, 2026
Merged
Fix error when trying to persist non-utf-8 title#2569acelaya merged 1 commit intoshlinkio:developfrom
acelaya merged 1 commit intoshlinkio:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2569 +/- ##
=============================================
- Coverage 94.61% 94.59% -0.03%
- Complexity 1637 1641 +4
=============================================
Files 273 273
Lines 5111 5124 +13
=============================================
+ Hits 4836 4847 +11
- Misses 275 277 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2564
Improve charset parsing of auto-resolved titles so that:
Content-Typeheader does not include the charset, we fall back to<meta charset>or<meta http-equiv="Content-Type">tags.Up until now, we would try to persist an un-parsed title, which causes an error if it is not utf-8.