Switch to using exception handling for errors. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added composer spec
Contribution by Sebastian Alvarez @aseba enabling CURLOPT_VERBOSE
|
merged at nickl-/curl@8dec78d |
Collect response->debug_log if debug is enabled. Header parsing is optional by default only the response body will be returned. If headers are chosen both request and response raw headers are kept. Still only the response is separated and collected in associative array.
Also added User agent composition.
For example, `Access-Control-Allow-Origin:*`
Use Composer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this will break backward compatibility but IMO it's very important to force programmers to handle curl errors, instead of passively handling them (via
->error()). It also removes the possible case where a person tries to treat the output ofrequestas an object causing a fatal error to be triggered.