-
Notifications
You must be signed in to change notification settings - Fork 48
fix: change all references of talosctl image default #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change all references of talosctl image default #285
Conversation
Signed-off-by: Kevin Tijssen <kevin.tijssen@siderolabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates documentation for Talos v1.12 to reflect the renaming of the talosctl image default command to two new commands: talosctl image k8s-bundle (for Kubernetes images) and talosctl image talos-bundle (for Talos system images). The changes ensure all command references throughout the documentation are consistent with the new naming.
Changes:
- Renamed
talosctl image defaulttotalosctl image k8s-bundlein CLI reference documentation - Added new
talosctl image talos-bundlecommand documentation for listing Talos system images - Updated command usage examples in image cache documentation to use the new command names
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| public/talos/v1.12/reference/configuration/cli.mdx | Updated CLI reference to replace image default with k8s-bundle and added new talos-bundle command documentation |
| public/talos/v1.12/reference/cli.mdx | Updated CLI reference with renamed commands and added talos-bundle subcommand |
| public/talos/v1.12/configure-your-talos-cluster/images-container-runtime/image-cache.mdx | Updated image cache examples to use k8s-bundle command and added air-gapped environment documentation using talos-bundle |
| public/talos/v1.12/configure-your-talos-cluster/images-container-runtime/image-cache-registry-mirror.mdx | Updated registry mirror example to use k8s-bundle command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
public/talos/v1.12/configure-your-talos-cluster/images-container-runtime/image-cache.mdx
Outdated
Show resolved
Hide resolved
Signed-off-by: Kevin Tijssen <kevin.tijssen@siderolabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
public/talos/v1.12/reference/cli.mdx:1802
- This example still references the deprecated
talosctl images defaultcommand. It should be updated to use eithertalosctl images k8s-bundleortalosctl images talos-bundledepending on the intended use case. For a general example, consider usingtalosctl images k8s-bundlesince it's the Kubernetes-focused replacement.
talosctl images default | talosctl images cache-create --image-cache-path=/tmp/talos-image-cache --images=-
public/talos/v1.12/reference/configuration/cli.mdx:1917
- This example still references the deprecated
talosctl images defaultcommand. It should be updated to use eithertalosctl images k8s-bundleortalosctl images talos-bundledepending on the intended use case. For a general example, consider usingtalosctl images k8s-bundlesince it's the Kubernetes-focused replacement.
talosctl images default | talosctl images cache-create --image-cache-path=/tmp/talos-image-cache --images=-
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kevin Tijssen <kevin.tijssen@siderolabs.com>
public/talos/v1.12/configure-your-talos-cluster/images-container-runtime/image-cache.mdx
Outdated
Show resolved
Hide resolved
…er-runtime/image-cache.mdx Co-authored-by: Justin Garrison <justinleegarrison@gmail.com> Signed-off-by: Kevin Tijssen <kevin.tijssen@siderolabs.com>
|
/m |
I have updated all references of
talosctl image defaultin v1.12