Move 3 functions to the appropriate util module.#34
Move 3 functions to the appropriate util module.#34martin-barta-sie wants to merge 1 commit intosiemens:masterfrom
Conversation
DDvO
left a comment
DDvO
left a comment
There was a problem hiding this comment.
Rather than moving the three functions, please just rename them.
| * @return ASN.1 representation of the DN, or null on error | ||
| *******************************************************************************/ | ||
| /* this function is used by the genCMPClient API implementation */ | ||
| X509_NAME* UTIL_parse_name(const char* dn, long chtype, bool multirdn); |
There was a problem hiding this comment.
I acknowledge the discrepancy between the name and the location of the function,
but better not move it to UTIL, which is meant just for stuff that does not fit better elsewhere.
Instead, just rename the function to include CERT rather than UTIL_.
| * @param no_duplicate flag governing whether to add cert if it is a duplicate | ||
| * @return true on success, else false | ||
| *******************************************************************************/ | ||
| bool UTIL_sk_X509_add1_cert(STACK_OF(X509) * sk, X509* cert, bool no_duplicate); |
There was a problem hiding this comment.
I acknowledge the discrepancy between the name and the location of the function,
but better not move it to UTIL, which is meant just for stuff that does not fit better elsewhere.
Instead, just rename the function to include CERT rather than UTIL_.
| * @return true on success, else false | ||
| *******************************************************************************/ | ||
| /* this function is used by the genCMPClient API implementation */ | ||
| int UTIL_sk_X509_add1_certs(STACK_OF(X509) * sk, OPTIONAL const STACK_OF(X509) * certs, int no_self_signed, |
There was a problem hiding this comment.
I acknowledge the discrepancy between the name and the location of the function,
but better not move it to UTIL, which is meant just for stuff that does not fit better elsewhere.
Instead, just rename the function to include CERT rather than UTIL_.
2 participants
No description provided.