Skip to content

Prepare v2.1; various small fixes on code, build system, docs, and version compatibility#67

Merged
DDvO merged 14 commits intomasterfrom
prepare_v2.1
Oct 28, 2025
Merged

Prepare v2.1; various small fixes on code, build system, docs, and version compatibility#67
DDvO merged 14 commits intomasterfrom
prepare_v2.1

Conversation

@DDvO
Copy link
Member

@DDvO DDvO commented Oct 17, 2025

To help with OSS clearing and build chains, now switch to version 2.1.

On this occasion, various small fixes.

@DDvO DDvO requested a review from Copilot October 17, 2025 07:13
@DDvO DDvO added bug Something isn't working enhancement New feature or request cleanup labels Oct 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares version 2.1 with various fixes targeting code quality, build system improvements, documentation updates, and OpenSSL version compatibility. The changes primarily focus on improving compatibility between OpenSSL 3.0 and earlier versions by using conditional compilation.

Key changes:

  • Added version-specific compatibility for OpenSSL 3.0+ using X509_VERIFY_PARAM_get0_host() instead of custom host storage
  • Fixed variable scope and type issues in logging and parsing functions
  • Updated build system requirements and version numbers across configuration files

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/libsecutils/src/util/log.c Moved variable declaration into debug scope and fixed type for string length
src/libsecutils/src/credentials/verify.c Removed obsolete comment about OpenSSL API limitations
src/libsecutils/src/credentials/store.c Added OpenSSL version guards for host storage and updated function signatures
src/libsecutils/src/credentials/credentials.c Fixed function signature formatting
src/libsecutils/src/credentials/cert.c Changed parameter type from long to int
src/libsecutils/src/connections/http.c Added macro for backward compatibility with OCSP_parse_url
src/libsecutils/src/connections/conn.c Added new IP address validation function
src/libsecutils/include/secutils/credentials/store.h Updated function signatures to use const pointers
src/libsecutils/include/secutils/credentials/credentials.h Fixed function signature formatting
src/libsecutils/include/secutils/credentials/cert.h Changed parameter type from long to int
src/libsecutils/include/secutils/connections/conn.h Replaced macro with function call for IP address check
debian/control Updated dependency version to 2.1
debian/changelog Added changelog entry for version 2.1
README.md Updated tested tool versions and clarified Debian package building
Makefile_v1 Updated VERSION to 2.1
CMakeLists.txt Updated minimum CMake version, project version, and improved OpenSSL detection

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DDvO DDvO force-pushed the prepare_v2.1 branch 2 times, most recently from e1a25cd to 20867de Compare October 17, 2025 07:44
@DDvO DDvO force-pushed the prepare_v2.1 branch 2 times, most recently from c41e627 to f65d66b Compare October 17, 2025 11:11
Copy link
Collaborator

@rajeev-0 rajeev-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DDvO DDvO merged commit 78ff537 into master Oct 28, 2025
6 checks passed
@DDvO
Copy link
Member Author

DDvO commented Oct 28, 2025

Thank you @benjamin-schilling and @rajeev-0 for your reviews.

I've just released libSecUtils 2.1, including the respective version tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants