Conversation
…successful getaddrinfo() call
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in the CONN_is_IP_address() function that occurs when getaddrinfo() fails and leaves the res pointer in an undefined state, which could then be incorrectly freed.
- Initialize the
respointer toNULLto prevent undefined behavior - Change the condition for freeing memory from checking
res != NULLto checkingret == 0to properly handlegetaddrinfo()return values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DDvO
changed the title
CONN_is_IP_address(): prevent crash freeing uninitialized 'res' on unsuccessful getaddrinfo() callCONN_is_IP_address(): prevent crash freeing uninitialized 'res' on unsuccessful getaddrinfo() call
benjamin-schilling
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will prevent a crash reported by a genCMPClient user: