chore: add ./bootstrap into rules to reduce requirements on build environment#28
Merged
chore: add ./bootstrap into rules to reduce requirements on build environment#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bootstrap step needs tools like libtool, autoconf, etc. These things are correctly added as Build-Depends in debian/control. But the problem is that ./bootstrap is supposed to be run before the Debian build, which means these tools must be installed beforehand. In some build environments, this might not be easy to do.
Moving it into debian/rules before configure seems to do the trick, and it's more in line with how normal Deb packages are supposed to work.