fix: do not announce non‑draggable headers as clickable #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fh1ch
approved these changes
Jan 18, 2026
Member
fh1ch
left a comment
fh1ch
left a comment
There was a problem hiding this comment.
@spike-rabbit nice one, thanks a lot for the fix 💯
LGTM 👍
In the draggable directive, only apply listeners, if the dragging is enabled. Otherwise, screen-reader will always announce them as clickable if dragging is disabled. Closes #583
fh1ch
force-pushed
the
fix/non-draggable-non-clickable
branch
from
b4956d2 to
d3257af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Column headers with dragging disabled are announced as clickable.
What is the new behavior?
Column headers with dragging disabled are not announced as clickable.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information:
This can be tested in the row-detail example:
Closes #583.