Skip to content

Conversation

@abeljohn
Copy link

@abeljohn abeljohn commented Sep 8, 2025

renames packages from @stitches/* to @sigmacomputing/stitches-* for publishing, and updates supporting files to work with yarn v4 and node 20

@abeljohn abeljohn requested a review from a team September 8, 2025 17:21
@slequar
Copy link

slequar commented Sep 8, 2025

Is there a description of what the larger changes were? Looks like there's a few big deletions (e: specifically of traces)

Copy link

@peternandersson peternandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this packages/test/*?

on:
push:
branches:
- canary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using this branch?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will not be using it actively, but since this is the branch our fork is based off of, we should keep it just in case we need to pull in changes from upstream

@@ -1,5 +1,5 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change this? I figure we're not actually using this for CI?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we can delete this since we aren't using codesandbox

@@ -0,0 +1 @@
v20.17.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just curious, why do we need a node version for this package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this just ensures consistency across builds by ensuring all builds were generated using the same tooling

@abeljohn
Copy link
Author

abeljohn commented Sep 8, 2025

Is there a description of what the larger changes were? Looks like there's a few big deletions

I removed packages/test/traces/* from version control, as those traces contain filesystem paths from whoever ran the tests. Keeping them in version control would lead to large diffs anytime the tests are run locally. AFAICT these traces do not need to be committed, and are mostly for debugging locally

Copy link

@rilescode rilescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Would it make sense to update the READMEs as well?

ie npm install @stitches/core -> npm install @sigmacomputing/stitches-core etc

@abeljohn
Copy link
Author

abeljohn commented Sep 8, 2025

Nice. Would it make sense to update the READMEs as well?

ie npm install @stitches/core -> npm install @sigmacomputing/stitches-core etc

let's do this when we start publishing the packages publicly

@abeljohn abeljohn force-pushed the abeljohn/repo-setup branch from 979e79d to 30c8f7e Compare September 8, 2025 22:32
@abeljohn abeljohn merged commit 7039e2e into main Sep 8, 2025
2 checks passed
@abeljohn abeljohn deleted the abeljohn/repo-setup branch September 8, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants