-
Notifications
You must be signed in to change notification settings - Fork 1
setup repo with yarn v4 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is there a description of what the larger changes were? Looks like there's a few big deletions (e: specifically of |
peternandersson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this packages/test/*?
| on: | ||
| push: | ||
| branches: | ||
| - canary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still using this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will not be using it actively, but since this is the branch our fork is based off of, we should keep it just in case we need to pull in changes from upstream
.codesandbox/ci.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to change this? I figure we're not actually using this for CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we can delete this since we aren't using codesandbox
| @@ -0,0 +1 @@ | |||
| v20.17.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just curious, why do we need a node version for this package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this just ensures consistency across builds by ensuring all builds were generated using the same tooling
I removed |
rilescode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Would it make sense to update the READMEs as well?
ie npm install @stitches/core -> npm install @sigmacomputing/stitches-core etc
let's do this when we start publishing the packages publicly |
979e79d to
30c8f7e
Compare
renames packages from
@stitches/*to@sigmacomputing/stitches-*for publishing, and updates supporting files to work with yarn v4 and node 20