Remove maximum number of channels limitation#340
Merged
777arc merged 1 commit intosigmf:mainfrom May 16, 2025
Merged
Conversation
In df53293, the SigMF spec was converted from Markdown to a JSON schema. Minimum and maximum values were added for many fields. In particular, the core:num_channels field got a maximum value of 1000. The Markdown specification did not specify a maximum value for core:num_channels, so in a sense this is a breaking change between v1.2.1 and v1.2.0 of the spec. The limitation breaks some usage of SigMF to represent channelizer data, such as the output of the a polyphase-filterbank, or (power-detected) spectrogram data. This removes the limitation by setting the max value to 2**63 - 1, which is the max value used for other fields.
Contributor
Author
|
I noticed this when some internal tooling that handles spectrogram data broke with a new release of |
Member
|
Change makes sense! Yep that's the process, but we can make sure to do it quick in this case, in fact I'll merge and tag the patch release now |
777arc
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In df53293, the SigMF spec was converted from Markdown to a JSON schema. Minimum and maximum values were added for many fields. In particular, the core:num_channels field got a maximum value of 1000. The Markdown specification did not specify a maximum value for core:num_channels, so in a sense this is a breaking change between v1.2.1 and v1.2.0 of the spec.
The limitation breaks some usage of SigMF to represent channelizer data, such as the output of the a polyphase-filterbank, or (power-detected) spectrogram data.
This removes the limitation by setting the max value to 2**63 - 1, which is the max value used for other fields.