Allow global.properties.core:sample_rate to be any number greater than 0#350
Merged
Teque5 merged 2 commits intosigmf:mainfrom Dec 21, 2025
Merged
Allow global.properties.core:sample_rate to be any number greater than 0#350Teque5 merged 2 commits intosigmf:mainfrom
Teque5 merged 2 commits intosigmf:mainfrom
Conversation
…e any number greater than 0 See sigmf#339 for discussion. There are cases where the sample rate of a system is less than 1 second. This change makes use of the JSON schema exclusiveMinimum keyword on ranges.
dkozel
added a commit
to dkozel/sigmf-example-files
that referenced
this pull request
Dec 21, 2025
Testing spec change in sigmf/SigMF#350
|
This is a nice, minimal, and accurate change. I tested against a minimal sigmf-meta file with a sample rate of 1/(60*60). |
Teque5
approved these changes
Dec 21, 2025
Collaborator
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #339 for discussion. There are cases where the sample rate of a system is less than 1 second. This change makes use of the JSON schema
exclusiveMinimumkeyword on ranges.