Skip to content

fix: improve error for insufficient blob data columns #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andrurachi wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

fix: improve error for insufficient blob data columns #8595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions beacon_node/http_api/src/block_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,8 +483,9 @@ impl BlockId {
},
)
} else {
Err(warp_utils::reject::custom_server_error(format!(
"Insufficient data columns to reconstruct blobs: required {num_required_columns}, but only {num_found_column_keys} were found."
Err(warp_utils::reject::custom_bad_request(format!(
"Insufficient data columns to reconstruct blobs: required {num_required_columns}, but only {num_found_column_keys} were found. \
You may need to run the beacon node with --supernode or --semi-supernode."
)))
}
}
Expand Down
4 changes: 2 additions & 2 deletions beacon_node/http_api/tests/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,8 +1970,8 @@ impl ApiTester {
.await
{
Ok(result) => panic!("Full node are unable to return blobs post-Fulu: {result:?}"),
// Post-Fulu, full nodes don't store blobs and return error 500
Err(e) => assert_eq!(e.status().unwrap(), 500),
// Post-Fulu, full nodes don't store blobs and return error 400 (Bad Request)
Err(e) => assert_eq!(e.status().unwrap(), 400),
};

self
Expand Down