Reorg Config Spec Modifications #8603
Open
+146
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Need to source
REORG_HEAD_WEIGHT_THRESHOLD,REORG_PARENT_WEIGHT_THRESHOLD,REORG_MAX_EPOCHS_SINCE_FINALIZATIONfrom config.yaml and include in spec APIWhich issue # does this PR address?
#8571
This is 2/2 PR to address the above issue, the other is #8601
Proposed Changes
as advised by feedback
proposer-reorg-threshold,proposer-reorg-parent-threshold, orproposer-reorg-epochs-since-finalizationare provided override the config from the config.yamlREORG_HEAD_WEIGHT_THRESHOLD,REORG_PARENT_WEIGHT_THRESHOLD,REORG_MAX_EPOCHS_SINCE_FINALIZATIONto /eth/v1/config/specAdditional Info
disable-proposer-reorgsbut after going back to phase0 spec I can see that its language implies that calling get_proposer_head is optional thus I'm leaving it as is.Testing
in addition to unit tests, curled the spec api and got