use @trap instead of posix.abort in custom panic handler#58
Closed
silbinarywolf wants to merge 1 commit intomainfrom
Closed
use @trap instead of posix.abort in custom panic handler#58silbinarywolf wants to merge 1 commit intomainfrom
silbinarywolf wants to merge 1 commit intomainfrom
Conversation
Owner
Author
|
Opting to just remove the custom panic handler from Zig 0.16.X onwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change custom panic handler to use @trap instead of posix.abort
Supposedly this does a better job of providing error messaging and while I haven't personally confirmed this, I see no reason not to make the switch for now.
Related to #54