Skip to content

replaced element function that causes badrecord later #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sile merged 1 commit into from
Feb 15, 2025
Merged

replaced element function that causes badrecord later #6

sile merged 1 commit into from
Feb 15, 2025

Conversation

@dw-kihara
Copy link
Contributor

@dw-kihara dw-kihara commented Feb 14, 2025

When flush_send_queue/1 returns {error, Reason, State} before entering loop/1, Reason from element(2, {error, Reason, State}) will passed to loop/1 causing badrecord eventually.
This pull request replaces the dangerous element/2 with case taking care of errors.

@sile
Copy link
Owner

sile commented Feb 15, 2025

Thank you for your PR.
I will review this PR today.

sile
sile approved these changes Feb 15, 2025
View reviewed changes
Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
Although the CI has failed, I will fix that after merging this PR.

@sile sile merged commit e04789d into sile:master Feb 15, 2025
0 of 3 checks passed
@dw-kihara
Copy link
Contributor Author

dw-kihara commented Feb 15, 2025

Thank you!

@dw-kihara dw-kihara deleted the fix/badrecord_in_gen_cop_server branch February 15, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sile sile sile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dw-kihara @sile