Skip to content

Conversation

@jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Dec 23, 2025

This fixes a regression in https://jira.sil.org/browse/LT-21902. The regression was caused by the commit at: 50c037d. The commit was to fix https://jira.sil.org/browse/LT-22096. Removing the call to TakeFocus fixed the regression without breaking LT-22096. I'm not sure why TakeFocus was added. Perhaps Mark Kidder remembers.

This also fixes the regression in https://jira.sil.org/browse/LT-21902 and https://jira.sil.org/browse/LT-22095.


This change is Reviewable

Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3).


Src/Common/Controls/DetailControls/DataTree.cs line 1500 at r1 (raw file):

				if (m_currentSlice != null)
				{
					m_currentSlice.TakeFocus(false);

Without the TakeFocus() call the steps in the original defect, LT-22096, would result in the moved field not having focus.  This would require the user to click on the field before typing.  Probably not a big issue, but would be better if we can maintain focus after a move. I think before removing the TakeFocus() call we should investigate further to see why the TakeFocus() call is resulting in these problems. My initial thought is that the new problems are occurring when the slice that is taking focus is newly created. In the original defect (LT-22096) the focus field was not created, just moved. I can either assist you in the investigation or do the investigation.  Whichever you prefer.

@jtmaxwell3 jtmaxwell3 closed this Dec 24, 2025
@jtmaxwell3 jtmaxwell3 deleted the regression/LT-21902 branch December 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants