SF-3661 Notify user when training data file format is invalid

[RaymondLuong3]

This PR will detect if a training data file contains rows that are invalid. Rows must have two columns of data. When a row contains fewer than 2 columns of data, the file will be rejected and the user is notified to check their data. If a row is blank, it will be skipped over.

---

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.81%. Comparing base (aac7d83) to head (1a537b3).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...L.XForge.Scripture/Services/TrainingDataService.cs	94.73%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3625   +/-   ##
=======================================
  Coverage   82.80%   82.81%           
=======================================
  Files         610      610           
  Lines       37446    37462   +16     
  Branches     6163     6166    +3     
=======================================
+ Hits        31009    31024   +15     
  Misses       5487     5487           
- Partials      950      951    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RaymondLuong3]

@RaymondLuong3 made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion.

---

test/SIL.XForge.Scripture.Tests/Services/TrainingDataServiceTests.cs line 603 at r1 (raw file):

        text = text.TrimEnd(); // Remove trailing new lines
        text = text.Replace("\r\n", " "); // Handle newlines in both linux and windows environments
        text = text.Replace("\n", " ");

When I used Environment.NewLine it was working locally and detecting the NewLine convention, but when this was run on GHA the excel file NewLine came back with the windows convention. I chose to just do a replace so it will be more robust.

Code quote:

        text = text.Replace("\r\n", " "); // Handle newlines in both linux and windows environments
        text = text.Replace("\n", " ");

[pmachapman]

@pmachapman reviewed 3 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3).

---

test/SIL.XForge.Scripture.Tests/Services/TrainingDataServiceTests.cs line 603 at r1 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

When I used Environment.NewLine it was working locally and detecting the NewLine convention, but when this was run on GHA the excel file NewLine came back with the windows convention. I chose to just do a replace so it will be more robust.

Good thinking.

---

src/SIL.XForge.Scripture/Services/TrainingDataService.cs line 331 at r1 (raw file):

                            }
                            if (
                                csvReader.ColumnCount != NumTrainingDataColumns

Given the exception message below, this should be csvReader.ColumnCount < NumTrainingDataColumns, as it is OK to upload a CSV file with 3 or more columns (for example, the third column might be a comment on the sentence pair, or a last updated date, or some other data), where columns 3 and higher are just ignored (this is the behavior of the Convert Excel logic).

Code quote:

csvReader.ColumnCount != NumTrainingDataColumns

[RaymondLuong3]

@RaymondLuong3 made 1 comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @pmachapman).

---

src/SIL.XForge.Scripture/Services/TrainingDataService.cs line 331 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

Given the exception message below, this should be csvReader.ColumnCount < NumTrainingDataColumns, as it is OK to upload a CSV file with 3 or more columns (for example, the third column might be a comment on the sentence pair, or a last updated date, or some other data), where columns 3 and higher are just ignored (this is the behavior of the Convert Excel logic).

Good thinking. I have updated the logic and tests to support 3 or more columns in csv/tsv files.

[pmachapman]

@pmachapman reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3).