Fix the static build on Darwin #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping! What do you think about this change? I think it should be uncontroversial since it's the same thing done for Linux. (Also, I'd hate to leave this unfixed in the next release.) |
pkgw
added a commit
to pkgw/tectonic
that referenced
this pull request
Dec 23, 2019
By "semi-static" I mean that the final binary is not statically linked, but that it only dynamically links with core system libraries. Higher-level like harfbuzz are linked into the executable statically. This is accomplished by an environment variable TECTONIC_PKGCONFIG_FORCE_SEMI_STATIC=1, since I discovered that the pkg-config-rs library's logic for encouraging static linking will turn it off in the common case that our static libraries live in standard system prefixes. Unfortunately, graphite2 seems to have issues with its various static builds (e.g. silnrsi/graphite#54) so we won't always get a super-minimal list of dependencies, but this seems to get us most of the way there, and I've coded it so that we should start doing better if/when graphite2 is fixed.
burrbull
pushed a commit
to burrbull/tectonic
that referenced
this pull request
Oct 29, 2020
By "semi-static" I mean that the final binary is not statically linked, but that it only dynamically links with core system libraries. Higher-level like harfbuzz are linked into the executable statically. This is accomplished by an environment variable TECTONIC_PKGCONFIG_FORCE_SEMI_STATIC=1, since I discovered that the pkg-config-rs library's logic for encouraging static linking will turn it off in the common case that our static libraries live in standard system prefixes. Unfortunately, graphite2 seems to have issues with its various static builds (e.g. silnrsi/graphite#54) so we won't always get a super-minimal list of dependencies, but this seems to get us most of the way there, and I've coded it so that we should start doing better if/when graphite2 is fixed.
burrbull
pushed a commit
to burrbull/tectonic
that referenced
this pull request
Oct 30, 2020
By "semi-static" I mean that the final binary is not statically linked, but that it only dynamically links with core system libraries. Higher-level like harfbuzz are linked into the executable statically. This is accomplished by an environment variable TECTONIC_PKGCONFIG_FORCE_SEMI_STATIC=1, since I discovered that the pkg-config-rs library's logic for encouraging static linking will turn it off in the common case that our static libraries live in standard system prefixes. Unfortunately, graphite2 seems to have issues with its various static builds (e.g. silnrsi/graphite#54) so we won't always get a super-minimal list of dependencies, but this seems to get us most of the way there, and I've coded it so that we should start doing better if/when graphite2 is fixed.
|
applied in #69 |
|
Hello! Would also love to see this get merged and enable static libraries for Homebrew, the macOS package manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.