fix: add support for promise-based handlers #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nduthoit
reviewed
Dec 19, 2025
src/index.ts
Outdated
| * ``` | ||
| */ | ||
| export function createAsyncHandler(app: Application): (event: RequestEvent, context: Context) => Promise<ResponseResult> { | ||
| return async (event: RequestEvent, context: Context): Promise<ResponseResult> => { |
There was a problem hiding this comment.
The async keyword is unnecessary since runAsync() already returns a Promise.
Suggested change
| return async (event: RequestEvent, context: Context): Promise<ResponseResult> => { | |
| return (event: RequestEvent, context: Context): Promise<ResponseResult> => { |
tests/integration-tests.test.ts
Outdated
| expect(result.multiValueHeaders['Content-Type']).to.eql([ 'application/json; charset=utf-8' ]); | ||
| }); | ||
|
|
||
| it('returns a Promise that rejects when an error occurs', async () => { |
There was a problem hiding this comment.
Suggested change
| it('returns a Promise that rejects when an error occurs', async () => { | |
| it('returns a Promise that resolves when an error occurs', async () => { |
onebytegone
force-pushed
the
async-handler
branch
from
9c7c415 to
f936fe0
Compare
nduthoit
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.