Product details item groups read property on null fix #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Product details item groups read property on null fix.
$groups->getFirst()can return null which was not guarded against.Sentry error caught access on null:
$groups->getFirst()->item_group(line 1134).If null there are zero groups.
Testing Instructions
Checkout PR in store working dir.
With
pnpm start --symlinks=store...Checkout coursehost master working dir.
https://berna.silverorange.com/course-host-ccme/work-USERNAME/www/admin/Product/Details?id=78 should return the UI without any exception errors.
Developer Checklist
Before requesting review for this PR, make sure the following tasks are
complete:
Reviewer Checklist
Before merging this PR, make sure the following tasks are complete: