FIX Ensure site tree expands to show current child#2114
Draft
GuySartorelli wants to merge 1 commit intosilverstripe:2.4from
Draft
FIX Ensure site tree expands to show current child#2114GuySartorelli wants to merge 1 commit intosilverstripe:2.4from
GuySartorelli wants to merge 1 commit intosilverstripe:2.4from
Conversation
51ab80d to
0ebeee7
Compare
There are various bugs related to expanding the site tree when the current item isn't loaded into the tree, which whis commit should fix.
0ebeee7 to
40cfdd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are various bugs related to expanding the site tree when the current item isn't loaded into the tree, which whis PR should fix.
Fixed scenarios
This PR fixes it by expanding the relevant parent after the child node is added to the tree.
self.jstree('load_node', -1);is called but results in an error (the main problem the linked issue is about)This PR fixes it by reinstating the mandatory callback passed to
load_nodewhich was removed in FIX jstree state when saving a page by retaining the open/closed state and selected node state #932Remaining scenarios
self.jstree('load_node', -1, callback);is called but nothing happens. Looks like that's not recursive.Issue