added parsing of [SIDE_DATA]...[/SIDE_DATA], which contains information about rotation and displaymatrix for some videos #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…information about camera orientation in some videos. parsing videos with these attributes raised an exception before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to parse a video file containing a [SIDE_DATA]...[/SIDE_DATA] section in the metadata of a video stream raised an exception before.
Now the side data sections should be properly parsed into FFStreamSideData objects with the proper attributes, displaymatrix and rotation in my case.
I also ran autopep8 on the file to standardize the formatting, because my vim configuration inserts spaces instead of tabs and I got a lot of syntax errors.