Refactor get_planes_data function #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point to the FAA data source that is a single zip file and have 'year' be NULL but retain for compatibility across other functions. Adjust the process_planes_master function to not delete the temporary folder holding this file so it can be accessed by the process_planes_ref function.
simonpcouch
requested changes
Dec 5, 2025
Owner
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Thanks for the PR! A few comments.
R/utils.R
Outdated
|
|
||
| # delete the temporary folder | ||
| unlink(x = planes_lcl, recursive = TRUE) | ||
| # unlink(x = planes_lcl, recursive = TRUE) # commented out so it can be used in process_planes_ref |
Owner
There was a problem hiding this comment.
Instead of commenting out lines, could you remove lines that are no longer used and then a leave a self-review on the PR explaining your change if you feel it's not self-explanatory?
R/utils.R
Outdated
|
|
||
| # put together the url to query the planes data at | ||
| # Note: year parameter is accepted for backward compatibility but not used | ||
| # as FAA now provides a single consolidated dataset instead of yearly files |
Owner
There was a problem hiding this comment.
The get_planes_data function is not exported, so you can just remove the year parameter altogether. :)
Removed unused year parameter and commented-out code for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point to the FAA data source that is a single zip file and have 'year' be NULL but retain for compatibility across other functions. Adjust the process_planes_master function to not delete the temporary folder holding this file so it can be accessed by the process_planes_ref function.