Add default value for year parameter in get_planes #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make default NULL because FAA doesn't provide data by year.
simonpcouch
requested changes
Dec 5, 2025
Owner
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Could you add a note in the year parameter documentation clarifying that the argument will be ignored and is around only for backward-compatibility? Currently that documentation is inherited from anyflights, but we can just add a new @param line.
Add backward-compatibility parameter for year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make default NULL because FAA doesn't provide data by year. Related to changes made in the underlying functions of get_planes in patch-1.