Update to coadd table #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You should use |
JBorrow
requested changes
Dec 18, 2025
Member
JBorrow
left a comment
JBorrow
left a comment
There was a problem hiding this comment.
I think we also need tests for these scenarios to check that the joins are all working, see https://github.com/simonsobs/mapcat/blob/main/tests/test_mapcat.py
Comment on lines
+39
to
+42
| sa_relationship_kwargs={ | ||
| "primaryjoin": "AtomicMapCoaddTable.coadd_id == CoaddMapToCoaddTable.parent_coadd_id", | ||
| "secondaryjoin": "AtomicMapCoaddTable.coadd_id == CoaddMapToCoaddTable.child_coadd_id", | ||
| }, |
Member
There was a problem hiding this comment.
I don't fully understand why these manual join relationships are necessary
Collaborator
Author
There was a problem hiding this comment.
I get this error if I omit those lines:
AmbiguousForeignKeysError: Could not determine join condition between parent/child tables on relationship AtomicMapCoaddTable.child_coadds - there are multiple foreign key paths linking the tables via secondary table 'link_coadd_map_to_coadd'. Specify the 'foreign_keys' argument, providing a list of those columns which should be counted as containing a foreign key reference from the secondary table to each of the parent and child tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicMapCoaddTableCoaddMapToCoaddTablelink table and related fields toAtomicMapCoaddTable