Adding agent for the Lightning Detector #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanyilun
reviewed
Mar 12, 2024
BrianJKoopman
requested changes
Mar 23, 2024
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks for the PR @felipecarrero! A few comments, questions, and requests below. Happy to discuss any of these in person too.
for more information, see https://pre-commit.ci
6 tasks
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Just checking in on this. One small comment the changes, but then also still need the docs page for this agent. Anything I can do to help with that?
BrianJKoopman
approved these changes
Jan 6, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
This is ready to go, just waiting for checks to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an agent for the lightning detector that recieves data through the local network via UDP.
Description
The agent opens a socket and binds a port (1110) then receives packages sent by the lightning detector, parses them into a dictionary and publishes them to the agent feed.
Motivation and Context
No agent for the lightning detector exists.
How Has This Been Tested?
Testing carried out in daq-dev and monitoring through Grafana.
Types of changes
Checklist: