Conversation
Collaborator
|
Thanks for the MR! Our team will review it and come back to you! |
proton-pass
suggested changes
Feb 7, 2025
|
|
||
| // Move cursor to the last character | ||
| binding.prefixEditText.setSelection(binding.prefixEditText.text.count()) | ||
| binding.prefixEditText.setSelection(binding.prefixEditText.text!!.count()) |
There was a problem hiding this comment.
If prefixEditText is ever null this will cause a crash. Could you update it to avoid it?
Contributor
Author
There was a problem hiding this comment.
Sorry I have no idea why I made those changes in the first place. 😄
There was a problem hiding this comment.
Hey, you added it because otherwise, it would cause a compilation error. Right now, reverting it makes the code fail to compile. The ideal approach would be to write it in a more null-safe way. For example, you could add a .orEmpty().
| fun Context.getVersionName(): String { | ||
| val packageInfo = packageManager.getPackageInfo(packageName, PackageManager.GET_ACTIVITIES) | ||
| return packageInfo.versionName | ||
| return packageInfo.versionName!! |
There was a problem hiding this comment.
If versionName is ever null this will cause a crash. Could you update it to avoid it?
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is not a redesign.
Closes #132