Conversation
nguyenkims
approved these changes
May 27, 2022
Contributor
nguyenkims
left a comment
There was a problem hiding this comment.
LGTM, just left a question
6438ce4 to
297ef45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs the following changes:
webpack.config.jsto the upgrades. (mostly theCopyWebpackPlugin)..jshintrcesversion (we were already using version 9 features and the IDE complained about it, so the only change it does is suppress these warnings).vue-textarea-autosize).A dependency that could not be upgraded to the latest version is
webpack(it has only been upgraded to v4), as some dependencies only support up to webpack 4, and crash if used with webpack v5.There are still a few high severity vulns due to the aforementioned libs that only support webpack 4. They can be reviewed in the future.
This PR closes: