Christy Elzey - Bootcamp Solutions#75
Open
clelzey wants to merge 19 commits intosimpleviewinc:masterfrom
Open
Conversation
Week 1.1 HTML Assessments and Week 1.2 CSS Assessments
Fixed for faster transition in 1.2.5
Completed JS Assessments
Completed Assessments for Flexbox and Grid
| <source media="(min-width:1440px)" srcset="https://via.placeholder.com/1600x720"> | ||
| <source media="(min-width:1024px)" srcset="https://via.placeholder.com/1200x540"> | ||
| <source media="(min-width:640px)" srcset="https://via.placeholder.com/800x360"> | ||
| <img src="https://via.placeholder.com/400x180" alt="" style="width:auto"> |
Contributor
There was a problem hiding this comment.
Setting the width to auto makes it not expand/contract to fill the space correctly.
Auto: https://www.screencast.com/t/gISf025v
100%: https://www.screencast.com/t/AuLWjh5UGJX
Contributor
Author
There was a problem hiding this comment.
This should be fixed now. I am not sure why I used 'auto' except it was probably in one of the videos.
| } | ||
| data.set('date', 'October 6, 1986'); | ||
| data.set('time', '21:13 PM'); | ||
| data.set('Powerful, spirited...'); |
Contributor
There was a problem hiding this comment.
This item needs a key of 'mood' like the others have. The value string contains a comma, but that doesn't change the key.
console.log(getInformation('date'));
console.log(getInformation('time'));
console.log(getInformation('mood')); // gives the error message
Contributor
Author
There was a problem hiding this comment.
I have added the key back into the map.
Fixes for comments on PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed HTML and CSS Assessments