Patrick Mooney - Bootcamp solutions#92
Open
pfmooney1 wants to merge 32 commits intosimpleviewinc:masterfrom
Open
Patrick Mooney - Bootcamp solutions#92pfmooney1 wants to merge 32 commits intosimpleviewinc:masterfrom
pfmooney1 wants to merge 32 commits intosimpleviewinc:masterfrom
Conversation
Author
|
[Progress] [To do] |
tiffanyhardin
requested changes
Jul 10, 2022
Contributor
tiffanyhardin
left a comment
tiffanyhardin
left a comment
There was a problem hiding this comment.
Hey Patrick,
Tis is looking good. Please review my notes and make the changes where requested.
Thanks, Tiffany
Week 1.1 - HTML/2. Create a Responsive Image - Resolution/index.html
Outdated
Show resolved
Hide resolved
Contributor
|
When you've make the code changes and are going to send this back, please also update the overview at the top to remove the inaccurate comments/questions. |
✔ Reversed source tag order and changed it to use min-width
✔ Removed "hgroup tag"
✔ Switched out underscores for dashes in class names to align with company style-guide
✔ switched to a triple-equals instead of a double-equals
✔ Switched out my .map function for a way simpler .map function
✔ Switched out my forEach function for a way simpler forEach function
Removed unnecessary code
Author
|
✔ Made the requested changes and edits |
Got rid of unnecessary code in the form tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Progress]
-CSS portion complete
-HTML portion complete
-JS portion
-CSS Grid portion
-Flexbox portion
-Made requested edits and changes