First backend commit #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simrathanspal
requested changes
Dec 5, 2024
Owner
There was a problem hiding this comment.
Push sample.env and add .env to gitignore
Owner
There was a problem hiding this comment.
We need to dockerise the application.
The docker files can go under the global project along side README.md
| API_V1_PREFIX: str = "/api/v1" | ||
| PROJECT_NAME: str = "AI Tutor" | ||
|
|
||
| # Security settings |
Owner
There was a problem hiding this comment.
WHat is the use of this code
| from pydantic_settings import BaseSettings | ||
| from functools import lru_cache | ||
|
|
||
| class Settings(BaseSettings): |
Owner
There was a problem hiding this comment.
Separate classes for different configs will be good.
| @@ -0,0 +1,49 @@ | |||
| from fastapi import FastAPI | |||
Owner
There was a problem hiding this comment.
Let's keep all endpoints under api folder
Owner
There was a problem hiding this comment.
Will need to be adapted to our usecase
Owner
There was a problem hiding this comment.
Will need to be adapted to our usecase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.