Process comments #10
Open
Process comments #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, the days would be rotated such that the days would be in their proper places with the designated first day of the week appearing in the leftmost column. Unfortunately the days of the week were not rotated. This commit fixes that problem.
README.md specifies this, but the code didn't follow it. This commit fixes that.
Owner
|
Thanks for the PR. I've incorporated this in #11 as part of making the CSV parsing more robust (2103615). Side-note: skipping the first line is required for my specific use case with a CSV which is an export of a spreadsheet of birthday dates where the first row is supposed to be a header row but not exported as a comment by Google Sheets (possibly because it's not formatted as a header row). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honors
#as a comment character. Removed code that ignores the first line of the.csvfile as superfluous. The only reason for that code that I can think of is for comments.