Skip to content

Improved coverage of property tests #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luisggpina wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved coverage of property tests #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/test/java/com/sinch/xms/BatchFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import static org.junit.Assume.assumeThat;

import com.pholser.junit.quickcheck.Property;
import com.pholser.junit.quickcheck.generator.InRange;
import com.pholser.junit.quickcheck.runner.JUnitQuickcheck;
import java.time.LocalDate;
import java.time.OffsetDateTime;
Expand Down Expand Up @@ -101,15 +102,15 @@ public void generatesValidQueryParameters(
assumeThat(senders, not(hasItem(containsString(","))));
assumeThat(tags, not(hasItem(containsString(","))));

BatchFilter filter =
BatchFilter.Builder builder =
SinchSMSApi.batchFilter()
.pageSize(pageSize)
.senders(senders)
.tags(tags)
.startDate(startDate)
.endDate(endDate)
.clientReference(clientReference)
.build();
.clientReference(clientReference);

BatchFilter filter = (senders.isEmpty()) ? builder.build() : builder.pageSize(pageSize).build();

List<NameValuePair> params = filter.toQueryParams(page);

Expand Down
8 changes: 4 additions & 4 deletions src/test/java/com/sinch/xms/DeliveryReportFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,15 @@ public void generatesValidQueryParameters(
String clientReference)
throws Exception {

DeliveryReportFilter filter =
DeliveryReportFilter.Builder builder =
SinchSMSApi.deliveryReportFilter()
.pageSize(pageSize)
.statuses(statuses)
.codes(codes)
.startDate(startDate)
.endDate(endDate)
.clientReference(clientReference)
.build();
.clientReference(clientReference);

DeliveryReportFilter filter = (codes.isEmpty()) ? builder.build() : builder.pageSize(pageSize).build();

List<NameValuePair> params = filter.toQueryParams(page);

Expand Down
4 changes: 3 additions & 1 deletion src/test/java/com/sinch/xms/GroupFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ public void generatesValidQueryParameters(int page, int pageSize, Set<String> ta
// Constrain `tags` to strings not containing ','
assumeThat(tags, not(hasItem(containsString(","))));

GroupFilter filter = SinchSMSApi.groupFilter().pageSize(pageSize).tags(tags).build();
GroupFilter.Builder builder = SinchSMSApi.groupFilter().tags(tags);

GroupFilter filter = (tags.isEmpty()) ? builder.build() : builder.pageSize(pageSize).build();

List<NameValuePair> params = filter.toQueryParams(page);

Expand Down
8 changes: 4 additions & 4 deletions src/test/java/com/sinch/xms/InboundsFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ public void generatesValidQueryParameters(
// Constrain `to` to strings not containing ','
assumeThat(to, not(hasItem(containsString(","))));

InboundsFilter filter =
InboundsFilter.Builder builder =
SinchSMSApi.inboundsFilter()
.pageSize(pageSize)
.recipients(to)
.startDate(startDate)
.endDate(endDate)
.clientReference(clientReference)
.build();
.clientReference(clientReference);

InboundsFilter filter = (to.isEmpty()) ? builder.build() : builder.pageSize(pageSize).build();

List<NameValuePair> params = filter.toQueryParams(page);

Expand Down