Open
Conversation
luisggpina
requested review from
GSvensk,
gkvasnsinch,
sunsee18,
thomasf147 and
zuzmaczek
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
We are trying to increase the coverage of property tests for Java programs, and we found a way to do so in your project.
When using builders, not providing a page size allows to reach more code than always providing a page size.
As such, this PR changes the property tests so that sometimes they don't provide a page size to the builder, thus reaching more code.
For instance, on
BatchFilterTest.generatesValidQueryParameters, not providing a page size causes the constructor onBatchFilterImplto reach methodBatchFilter.pageSize, which otherwise would not be reached by this test.The argument for all the other tests is similar.