Improve mapper error stack traces #82
Draft
+178
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
commented
Sep 19, 2025
Comment on lines
+14
to
+26
| // Node.js and Chrome: '\n at ' | ||
| if (capturedStack.includes('\n at ')) { | ||
| frameSeparator = '\n at '; | ||
| } else if (capturedStack.includes('@')) { | ||
| // Firefox: '\n' (simpler format) | ||
| frameSeparator = '\n'; | ||
| } else if (capturedStack.includes('\n\t')) { | ||
| // Safari/JSC: varies, try common patterns | ||
| frameSeparator = '\n\t'; | ||
| } else { | ||
| // Fallback to generic newline separation | ||
| frameSeparator = '\n'; | ||
| } |
Owner
Author
There was a problem hiding this comment.
I haven't extensively tested this yet. Will do if we decide to do accept this PR.
Owner
Author
|
@Richienb Thoughts? |
Contributor
|
I think it would be ok to enable by default because the happy path won't receive a performance hit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
It's opt-in since it does come with a tiny performance overhead.
From a lot of research, this is the only way I managed to preserve the stack trace.