Skip to content

fix pager processing even in commits API #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomoo-morikawa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix pager processing even in commits API #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions tap_gitlab/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,18 +115,19 @@ def request(url, params=None):


def gen_request(url):
params = {'page': 1}
resp = request(url, params)
last_page = int(resp.headers.get('X-Total-Pages', 1))

for row in resp.json():
yield row

for page in range(2, last_page + 1):
params['page'] = page
flag = False
page = 1
while flag == False:
params = {'page': page}
resp = request(url, params)
for row in resp.json():
yield row
if (page + 1 == int('0' + resp.headers.get('x-next-page'))):
flag = False
else:
flag = True
page += 1


def format_timestamp(data, typ, schema):
result = data
Expand Down