Respect the schema passed in the stream.#29
Open
cgardens wants to merge 1 commit intosinger-io:masterfrom
Open
Respect the schema passed in the stream.#29cgardens wants to merge 1 commit intosinger-io:masterfrom
cgardens wants to merge 1 commit intosinger-io:masterfrom
Conversation
* Extract headers from schema object and use those headers to write to the CSV. * Write tests that flatten and get_headers produce the same keys.
Contributor
|
Hi @cgardens, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Contributor
|
You did it @cgardens! Thank you for signing the Singer Contribution License Agreement. |
Adam-D-Lewis
approved these changes
Oct 19, 2020
sherifnada
approved these changes
Nov 25, 2020
sherifnada
approved these changes
Jul 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract headers from schema object and use those headers to write to the CSV.
Write tests that flatten and get_headers produce the same keys.
Description of change
Currently this integration does not use schema to set headers in the CSV files. It instead relies on what is already in the file or the keys it can find in the record. I believe this is the source of these issues #3 and #22. My understanding of the singer spec is that it would be appropriate to use the schema records to make sure the correct headers are used in the CSV files, instead of sampling records.
Manual QA steps
Risks
Rollback steps