Change Application.isEditor check order in InitializeSingularSDK in editor#15
Open
VsIG-official wants to merge 3 commits intosingular-labs:mainfrom
Open
Change Application.isEditor check order in InitializeSingularSDK in editor#15VsIG-official wants to merge 3 commits intosingular-labs:mainfrom
Application.isEditor check order in InitializeSingularSDK in editor#15VsIG-official wants to merge 3 commits intosingular-labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1.
AwakeandInitializeSingularSDKinitialization flow order in editorWhile initializing SingularSDK via
InitializeSingularSDKin the Unity Editor I've encountered errorSingularSDK InitializeSingularSDK, no instance available - cannot initialize.It seems like strange behavior to Me because this error occurs when there's no
SingularSDKinstance, however, it's impossible for the instance to exist because there's a check inAwakebefore its creation to ensure, if We are in the editor, thenreturn.So in My PR I've changed
Awaketo be more likeInitializeSingularSDK: firstly check if We're in the editor and then - if We have an instance ofSingularSDKBefore fix:
if(Application.isEditor)->if(instance)if(!instance)->if(Application.isEditor)After fix:
if(Application.isEditor)->if(instance)if(Application.isEditor)->if(!instance)Commit
2.
Privatekeywords, whitespaces and unused methodsAlso I've added
privatekeywords to Unity methods and deleted some whitespaces + unusedUpdatemethodCommit 'whitespaces and unused methods'
Commit 'access keywords'