Skip to content

Add a link.xml for the runtime sdk to make sure no classes are stripped#21

Closed
JohannesDeml wants to merge 1 commit intosingular-labs:mainfrom
JohannesDeml:bugfix/preserve-runtime-assebly-all-classes
Closed

Add a link.xml for the runtime sdk to make sure no classes are stripped#21
JohannesDeml wants to merge 1 commit intosingular-labs:mainfrom
JohannesDeml:bugfix/preserve-runtime-assebly-all-classes

Conversation

@JohannesDeml
Copy link

@JohannesDeml JohannesDeml commented Feb 22, 2025

With Managed Stripping set to Low Deep links didn't work anymore, this makes sure that the functionality is preserved, see also https://support.singular.net/hc/en-us/requests/147468

This PR does not require to add the setting to the main link.xml in the project anymore (since that can easily be overseen and it was hard to actually find the problem, which you can also see in the support ticket). Hopefully this change will save others some time :)

…ed with managed stripping enabled

With Managed Stripping set to Low Deep links didn't work anymore, this makes sure that the functionality is preserved, see also https://support.singular.net/hc/en-us/requests/147468
@MaxEliezerSingular
Copy link

Hi @JohannesDeml

Thanks for the contribution!
We’ve officially included the preserve fix in our latest v5.7.0 release.
This should definitely help developers avoid those tricky deep-linking issues caused by code stripping.
We appreciate the help in making the SDK more robust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments