Remove duplicate tag proposals #579
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalen
reviewed
Dec 10, 2025
| from django.db import migrations | ||
| from django.db.models import Count | ||
|
|
||
| def cleanup_duplicate_proposals(apps, schema_editor): |
Contributor
There was a problem hiding this comment.
have you tried how fast it is on large data?
Contributor
There was a problem hiding this comment.
some ideas how to make it more efficient: https://stackoverflow.com/questions/5877306/remove-duplicates-in-a-django-query
Author
There was a problem hiding this comment.
considering there are around ~300 rows to delete this is shouldn't be a problem, I added the optimization either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #573
Adds a unique constraint to
DifficultyTagProposalfor(problem, user)and toAlgorithmTagProposalfor(problem, tag, user).The migration cleans up the duplicates before applying the new constraints