Automatic node modules actualization #605
Open
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any package is missing or has a wrong version, the script runs `npm install` automatically when the container starts. This fixes the issue with empty node_modules on fresh install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the problem where web container crashes after MathJax's git pull because of missing node_modules.
When running docker-compose, the local folder (volume) overrides the files inside the container. Because of this,
node_moduleswas missing 'copy-webpack-plugin' and the server didn't start.The fix:
I updated
oioioi_init.sh: I added a dependancies check using:npm list --depth=0:up), it checks if your installed packages matchpackage.json.npm listreturns an error (missing files or wrong version), it runsnpm installinside the container automatically.npm run buildto copy assets.This should work for any new library we add in the future, not just MathJax.
Note: you may need to take your's containers down before you make them up using my version of oioioi_init.sh.