docs: document re-entrancy and integration constraints#26
Conversation
Add Integration Constraints section to limitations.md: - One first::test() per #[test] - Async tests not supported - Not thread-safe - No nested workspaces Add limitations summary to lib.rs crate docs. Closes #18
Summary of ChangesHello @siphonite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds important documentation regarding the limitations and integration constraints of the FIRST framework. The changes are clear and add value by setting correct user expectations. I've provided a couple of minor suggestions to improve the consistency and completeness of the new documentation.
| ### No Nested Workspaces | ||
|
|
||
| | Pattern | Status | | ||
| |---------|--------| | ||
| | User-managed dirs inside `env.path()` | ✅ Supported | | ||
| | Expecting FIRST to manage nested isolation | ❌ Not supported | | ||
|
|
There was a problem hiding this comment.
This section is missing a rationale, unlike the other sections under 'Integration Constraints'. Adding a rationale would improve clarity for users and maintain consistency in the document. The limitation seems to be due to global state like environment variables and a fixed temporary directory.
| ### No Nested Workspaces | |
| | Pattern | Status | | |
| |---------|--------| | |
| | User-managed dirs inside `env.path()` | ✅ Supported | | |
| | Expecting FIRST to manage nested isolation | ❌ Not supported | | |
| ### No Nested Workspaces | |
| | Pattern | Status | | |
| |---------|--------| | |
| | User-managed dirs inside `env.path()` | ✅ Supported | | |
| | Expecting FIRST to manage nested isolation | ❌ Not supported | | |
| **Rationale**: FIRST relies on global resources like environment variables and a fixed base directory (`/tmp/first`) for orchestration. Nested test environments would conflict over these resources, leading to undefined behavior. |
Summary
Documents what FIRST v0.1 does NOT support, so users don't infer guarantees that don't exist.
Changes
docs/limitations.mdAdd new "Integration Constraints (v0.1)" section:
first::test()per#[test]src/lib.rsAdd limitations summary to crate documentation.
Verification
cargo fmt -- --check✅cargo clippy -- -D warnings✅cargo test --doc✅Closes #18