Skip to content

docs: document re-entrancy and integration constraints#26

Merged
siphonite merged 1 commit intomainfrom
issue-18-reentrant-docs
Feb 6, 2026
Merged

docs: document re-entrancy and integration constraints#26
siphonite merged 1 commit intomainfrom
issue-18-reentrant-docs

Conversation

@siphonite
Copy link
Owner

Summary

Documents what FIRST v0.1 does NOT support, so users don't infer guarantees that don't exist.

Changes

docs/limitations.md

Add new "Integration Constraints (v0.1)" section:

  • One first::test() per #[test]
  • Async tests not supported
  • Not thread-safe
  • No nested workspaces

src/lib.rs

Add limitations summary to crate documentation.

Verification

  • cargo fmt -- --check
  • cargo clippy -- -D warnings
  • cargo test --doc

Closes #18

Add Integration Constraints section to limitations.md:
- One first::test() per #[test]
- Async tests not supported
- Not thread-safe
- No nested workspaces

Add limitations summary to lib.rs crate docs.

Closes #18
@gemini-code-assist
Copy link

Summary of Changes

Hello @siphonite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation for the FIRST testing framework by clearly outlining its current limitations and integration constraints for version 0.1. The primary goal is to prevent users from inferring unsupported guarantees, thereby improving the clarity and robustness of the framework's usage guidelines. This ensures that developers understand the specific scenarios where FIRST can and cannot be effectively applied, particularly concerning re-entrancy, asynchronous testing, thread safety, and workspace management.

Highlights

  • Integration Constraints Documentation: Added a new, comprehensive section to docs/limitations.md detailing integration constraints for FIRST v0.1, clarifying supported and unsupported usage patterns with rationales.
  • Crate-Level Limitations Summary: Updated the src/lib.rs crate documentation to include a high-level summary of key limitations, directing users to the detailed docs/limitations.md for more information.
  • Specific Limitations Clarified: Explicitly documented that first::test() should be used once per #[test], async tests are not supported, the framework is not thread-safe, and nested workspaces are not managed by FIRST.
Changelog
  • docs/limitations.md
    • Introduced a new section titled "Integration Constraints (v0.1)".
    • Detailed specific patterns for first::test() usage, async test support, thread safety, and nested workspaces.
    • Provided clear "Supported" (✅) and "Undefined/Not supported" (❌) statuses for each pattern, along with rationales for the limitations.
  • src/lib.rs
    • Added a new "Limitations (v0.1)" section to the crate-level documentation.
    • Listed key limitations including: one first::test() per #[test], no async tests, not thread-safe, and no nested workspaces.
    • Included a reference to docs/limitations.md for complete details on these limitations.
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@siphonite siphonite merged commit e551681 into main Feb 6, 2026
1 check passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds important documentation regarding the limitations and integration constraints of the FIRST framework. The changes are clear and add value by setting correct user expectations. I've provided a couple of minor suggestions to improve the consistency and completeness of the new documentation.

Comment on lines +181 to +187
### No Nested Workspaces

| Pattern | Status |
|---------|--------|
| User-managed dirs inside `env.path()` | ✅ Supported |
| Expecting FIRST to manage nested isolation | ❌ Not supported |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This section is missing a rationale, unlike the other sections under 'Integration Constraints'. Adding a rationale would improve clarity for users and maintain consistency in the document. The limitation seems to be due to global state like environment variables and a fixed temporary directory.

Suggested change
### No Nested Workspaces
| Pattern | Status |
|---------|--------|
| User-managed dirs inside `env.path()` | ✅ Supported |
| Expecting FIRST to manage nested isolation | ❌ Not supported |
### No Nested Workspaces
| Pattern | Status |
|---------|--------|
| User-managed dirs inside `env.path()` | ✅ Supported |
| Expecting FIRST to manage nested isolation | ❌ Not supported |
**Rationale**: FIRST relies on global resources like environment variables and a fixed base directory (`/tmp/first`) for orchestration. Nested test environments would conflict over these resources, leading to undefined behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document Re-entrancy & Integration Expectations

1 participant