Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates transaction queue memo filtering for Soroban transactions by simplifying the validation logic. The change removes the complex source account authentication checking and instead applies a blanket restriction on memos and muxed accounts for all Soroban invoke host function operations.
Key changes:
- Simplifies memo validation logic by removing source account authentication type checking
- Updates corresponding test expectations to reflect stricter validation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/herder/TransactionQueue.cpp | Removes complex authentication type checking and simplifies memo/muxed account validation for Soroban transactions |
| src/herder/test/TransactionQueueTests.cpp | Updates test expectation from ADD_STATUS_PENDING to ADD_STATUS_ERROR to match new validation behavior |
| txEnv.tx.sourceAccount.type() == | ||
| CryptoKeyType::KEY_TYPE_MUXED_ED25519 || | ||
| (op.sourceAccount && | ||
| op.sourceAccount->type() == CryptoKeyType::KEY_TYPE_MUXED_ED25519)) |
There was a problem hiding this comment.
This change modifies transaction validation logic that could affect fee bump transactions. Should we add or update tests for fee bump transactions to ensure they still work correctly with this new memo filtering behavior?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #X
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)