Skip to content

Conversation

@kylege
Copy link

@kylege kylege commented Mar 17, 2018

No description provided.

@fgregg
Copy link

fgregg commented Nov 14, 2018

This looks like the right approach to address #2. The test is not passing because the test is not using an actual file but a stringIO object (which has a file like interface). Is it important for tailer to work on file-like objects or is it okay for it just to work on files?

If it's okay to just work on files, then, I can fix up the tests.

If you want the test to pass on file-like objects like stringIO I can alter the code to handle that case.

@six8
Copy link
Owner

six8 commented Nov 14, 2018

tailer should work on any file-like-object. One of the reasons it was created was to work on sockets and StringIO because normal tail does not.

@fgregg
Copy link

fgregg commented Nov 14, 2018

Got it! Thanks.

@fgregg
Copy link

fgregg commented Nov 14, 2018

@six8, thanks for the quick response. I'm going to go with tailhead which is more oriented to files (and which builds on your great work here). Thanks again for the useful library.

@cunhar
Copy link

cunhar commented Feb 1, 2021

is the idea of adding this dead?

@pboushy
Copy link

pboushy commented Feb 26, 2022

I'm also curious if this idea is dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants