Add option for restriction of SELECT queries from user_model#17
Merged
Add option for restriction of SELECT queries from user_model#17
Conversation
xdaniel3
commented
Jan 5, 2026
xdaniel3
commented
- in case that user_model is very wide this can save some resources
xdaniel3
force-pushed
the
tda/add_user_model_columns_option
branch
2 times, most recently
from
3471973 to
283e10d
Compare
Pull Request Test Coverage Report for Build 20899885394Details
💛 - Coveralls |
xkubov
reviewed
Jan 6, 2026
| 'http://localhost:8000/current_time_backend/') | ||
| assert_equal(reverse('current-datetime', site_id=settings.FRONTEND_SITE_ID, add_domain=True), | ||
| 'https://localhost/current_time_frontend/') | ||
| def test_get_user_uses_only_when_columns_specified(self): |
Collaborator
There was a problem hiding this comment.
nitpick: the name is slightly confusing, if i didn't know the usage of user_model_columns causes call of only method on the queryset I might have felt the name is missing a noun 😄
xkubov
approved these changes
Jan 6, 2026
- in case that user_model is very wide this can save some resources
xdaniel3
force-pushed
the
tda/add_user_model_columns_option
branch
from
283e10d to
e2d8c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.