Skip to content

Remove implicit ISODateTimeField#3

Open
Formulka wants to merge 1 commit intoskip-pay:masterfrom
Formulka:RemoveImplicitISODateTimeField
Open

Remove implicit ISODateTimeField#3
Formulka wants to merge 1 commit intoskip-pay:masterfrom
Formulka:RemoveImplicitISODateTimeField

Conversation

@Formulka
Copy link

No description provided.


def formfield_for_dbfield(self, db_field, **kwargs):
if isinstance(db_field, DateTimeField):
kwargs.update({'form_class': ISODateTimeField})
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not exist in such a base class

@Formulka Formulka force-pushed the RemoveImplicitISODateTimeField branch from d322cb9 to 0e4b583 Compare February 16, 2023 15:19
@coveralls
Copy link

coveralls commented Feb 16, 2023

Pull Request Test Coverage Report for Build 4195441420

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 4054855827: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@xkubov
Copy link
Collaborator

xkubov commented Dec 3, 2025

is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants