SecuritySession updated to be able to use custom logger#13
Merged
xkubov merged 1 commit intoskip-pay:masterfrom Feb 3, 2025
Merged
SecuritySession updated to be able to use custom logger#13xkubov merged 1 commit intoskip-pay:masterfrom
xkubov merged 1 commit intoskip-pay:masterfrom
Conversation
xkubov
reviewed
Feb 3, 2025
stehlfi1
force-pushed
the
feat/custom-logger-support
branch
2 times, most recently
from
ba11ba5 to
0526b17
Compare
xkubov
requested changes
Feb 3, 2025
security/requests.py
Outdated
| class SecuritySession(Session): | ||
|
|
||
| def __init__(self, slug=None, related_objects=None): | ||
| def __init__(self, logger_class=OutputRequestLogger, slug=None, related_objects=None): |
There was a problem hiding this comment.
another thing. When You add an optional argument add it to the end of the argument list, please. Not at the beginning.
Pull Request Test Coverage Report for Build 13111551410Details
💛 - Coveralls |
stehlfi1
force-pushed
the
feat/custom-logger-support
branch
from
0526b17 to
568e01e
Compare
xkubov
reviewed
Feb 3, 2025
stehlfi1
force-pushed
the
feat/custom-logger-support
branch
from
568e01e to
a7fb5d6
Compare
xkubov
approved these changes
Feb 3, 2025
Formulka
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecuritySession updated to be able to use custom logger